Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix learning on cuda #201

Merged
merged 10 commits into from
Sep 25, 2023
Merged

Fix learning on cuda #201

merged 10 commits into from
Sep 25, 2023

Conversation

nick-harder
Copy link
Member

I have performed testing on cuda devices and some fixes had to be done. Also in this commit all yaml files are changed to standart yaml file type (before we had a mix of yml and yaml).

-added input files
-adjusted parameters
-saved the learning strategy as a stand alone file
-not tested yet
-removed the float16 option
-as this requires deeper changes
-fixed pandas future warning in outputs
-when df is empty
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch coverage: 89.65% and project coverage change: +1.95% 🎉

Comparison is base (da753d5) 79.00% compared to head (8b17b3e) 80.95%.

❗ Current head 8b17b3e differs from pull request most recent head b286934. Consider uploading reports for the commit b286934 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   79.00%   80.95%   +1.95%     
==========================================
  Files          40       40              
  Lines        4048     4053       +5     
==========================================
+ Hits         3198     3281      +83     
+ Misses        850      772      -78     
Flag Coverage Δ
pytest 80.95% <89.65%> (+1.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...einforcement_learning/algorithms/base_algorithm.py 95.45% <0.00%> (ø)
assume/common/units_operator.py 90.81% <81.81%> (-0.40%) ⬇️
assume/common/outputs.py 81.53% <100.00%> (+0.09%) ⬆️
assume/common/scenario_loader.py 89.00% <100.00%> (+1.04%) ⬆️
assume/reinforcement_learning/buffer.py 81.81% <100.00%> (ø)
assume/reinforcement_learning/learning_role.py 68.60% <100.00%> (+1.93%) ⬆️
assume/strategies/learning_strategies.py 95.04% <100.00%> (+2.47%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments to things which are not clear to me :)

assume/common/outputs.py Outdated Show resolved Hide resolved
assume/common/base.py Outdated Show resolved Hide resolved
assume/common/units_operator.py Outdated Show resolved Hide resolved
@maurerle maurerle force-pushed the fix-learning-on-cuda branch from 2aa152a to b286934 Compare September 25, 2023 10:08
@maurerle maurerle merged commit 570ce3c into main Sep 25, 2023
0 of 2 checks passed
@maurerle maurerle deleted the fix-learning-on-cuda branch September 25, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants