fix simulation runs wrong reporting learning_mode #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set the current episode correctly in run_learning set learning_mode once, now that we have it in outputs directly add simulation_id to tqdm remove learning_mode from outputs fix query if accepted_price is not float (whysoever)
maurerle
force-pushed
the
fix_episodes
branch
from
0a89361 to
cc598c6
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
=======================================
Coverage 79.00% 79.00%
=======================================
Files 40 40
Lines 4048 4048
=======================================
Hits 3198 3198
Misses 850 850
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
nick-harder
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set the current episode correctly in run_learning
set learning_mode once, now that we have it in outputs directly add simulation_id to tqdm
remove learning_mode from outputs
fix query if accepted_price is not float (whysoever)