Enable saving results only at the end of the simulation #193
Conversation
-fixes cvs_path creating an empty folder when not defined
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
=======================================
Coverage 79.00% 79.00%
=======================================
Files 40 40
Lines 4048 4048
=======================================
Hits 3198 3198
Misses 850 850
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
| learning_mode: bool = False, | ||
| ): | ||
| super().__init__() | ||
|
|
||
| # store needed date | ||
| self.simulation_id = simulation_id | ||
| self.save_frequency_hours = save_frequency_hours | ||
| self.save_frequency_hours = save_frequency_hours or (end - start).days * 24 |
There was a problem hiding this comment.
When would you want to disable saving results in given intervals?
Stating "same_process=False" should fix consuming performance, by using a separate process
The remaining data will always be written in on_stop of the outputs role
There was a problem hiding this comment.
as of right now this saving each day consumes a big chunk of time as multithread is not working. We should have this until second thread works. Also, sometime you really don't need all that data every day of the run...
There was a problem hiding this comment.
I believe this is also not because of the db, but the csv files, those require a lot of time
|
@maurerle soll es durch? |
|
Ich wollte es noch nachstellen, ob das = None tatsächlich notwendig ist.. |
|
ach ja stimmt, jetzt ist 24 wieder default |
-adds a function to store all results at the end
-fixes cvs_path creating an empty folder when not defined