Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check open market auctions #192

Merged
merged 2 commits into from
Sep 16, 2023
Merged

check open market auctions #192

merged 2 commits into from
Sep 16, 2023

Conversation

maurerle
Copy link
Member

check that an orderbook is in one of the open auctions
clear all_orders to fix piling up orders
improve rejecting orders

fixes #187
fixes #190

clear up all_orders to fix piling up orders
clean up setting accepted_volume and price on rejected orders
fix setting the volume of the split order in clearing
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 93.75% and project coverage change: -0.10% ⚠️

Comparison is base (dd9c0e9) 79.07% compared to head (0d5e42d) 78.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
- Coverage   79.07%   78.97%   -0.10%     
==========================================
  Files          40       40              
  Lines        4047     4043       -4     
==========================================
- Hits         3200     3193       -7     
- Misses        847      850       +3     
Flag Coverage Δ
pytest 78.97% <93.75%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...sume/markets/clearing_algorithms/all_or_nothing.py 90.62% <ø> (-0.73%) ⬇️
...me/markets/clearing_algorithms/complex_clearing.py 90.78% <ø> (-0.07%) ⬇️
assume/markets/clearing_algorithms/simple.py 95.71% <85.71%> (-2.15%) ⬇️
assume/markets/base_market.py 89.26% <100.00%> (+0.31%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nick-harder nick-harder merged commit 40e6cac into main Sep 16, 2023
3 of 4 checks passed
@nick-harder nick-harder deleted the market_fixes branch September 16, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants