Try to migrate the existing database, by adding missing columns #191
Conversation
supports float and text columns
maurerle
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
- Coverage 79.35% 79.07% -0.29%
==========================================
Files 40 40
Lines 4026 4047 +21
==========================================
+ Hits 3195 3200 +5
- Misses 831 847 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
| If a simulation before has been started which does not include an additional field | ||
| we try to add the field. | ||
| For now, this only works for float and text. | ||
| An alternative which finds the correct types would be to use |
There was a problem hiding this comment.
What other types there might be? anyway we cannot write dicts or enything else.
There was a problem hiding this comment.
we do not detect bool or datetime values. But for most use cases it will be enough
There was a problem hiding this comment.
so maybe we can for now add a raise if the type is not detected? so we see if the problem ever occurs. Or it won't work anyway?
There was a problem hiding this comment.
If the field is bool (0 or 1) or int, we will add it as float numeric.
Datetime might be added as unix timestamp numeric or raise an error.
This will probably be enough to visualize the values, even if it is not the proper datatype.
And in other cases it will raise anyway. So I don't think we need additional error raising
supports float and text columns
simplifies database engine usage as pandas now fully supports sqlalchemy v2
fixes #188