Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added VavrInstanceOfAssertFactories helper class #207

Merged
merged 5 commits into from
Feb 4, 2024
Merged

Added VavrInstanceOfAssertFactories helper class #207

merged 5 commits into from
Feb 4, 2024

Conversation

edudar
Copy link
Contributor

@edudar edudar commented Jan 19, 2024

Added VavrInstanceOfAssertFactories helper class, which is structurally identical to the original InstanceOfAssertFactories. VavrAssertions now "implement" it, same as original Assertions.

Closes #134

@edudar
Added VavrInstanceOfAssertFactories helper class, which is structural…
310c7f8 
…ly identical to the original InstanceOfAssertFactories. VavrAssertions now "implement" it, same as original Assertions.
@edudar edudar requested a review from mchmielarz as a code owner January 19, 2024 18:19
@mchmielarz mchmielarz self-assigned this Jan 21, 2024
@mchmielarz mchmielarz added this to the v0.5.0 milestone Jan 21, 2024
@edudar
Copy link
Contributor Author

edudar commented Jan 21, 2024 •
edited
Loading

My only reservation here is try because it can't follow the existing convention, so it's _try with an underscore.

@mchmielarz mchmielarz merged commit 022114d into assertj:main Feb 4, 2024
4 checks passed
@edudar edudar deleted the vavr-instance-of-assert-factories branch February 6, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchmielarz mchmielarz mchmielarz approved these changes

Assignees

@mchmielarz mchmielarz

Labels
enhancement
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

[Feature Request] Provide a vavr version of InstanceOfAssertFactories
2 participants
@edudar @mchmielarz