Improved request error handling.

aspnet · Nov 3, 2017 · 1b5ba87 · 1b5ba87
1 parent 9e4ab16
commit 1b5ba87
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/src/Microsoft.AspNetCore.Server.HttpSys/AsyncAcceptContext.cs b/src/Microsoft.AspNetCore.Server.HttpSys/AsyncAcceptContext.cs
@@ -6,6 +6,7 @@
 using System.Diagnostics.Contracts;
 using System.Threading;
 using System.Threading.Tasks;
+using Microsoft.AspNetCore.Http;
 
 namespace Microsoft.AspNetCore.Server.HttpSys
 {
@@ -79,6 +80,11 @@ private static void IOCompleted(AsyncAcceptContext asyncResult, uint errorCode,
                                 complete = true;
                             }
                         }
+                        catch (Exception)
+                        {
+                            server.SendError(asyncResult._nativeRequestContext.RequestId, StatusCodes.Status400BadRequest);
+                            throw;
+                        }
                         finally
                         {
                             if (stoleBlob)

diff --git a/src/Microsoft.AspNetCore.Server.HttpSys/HttpSysListener.cs b/src/Microsoft.AspNetCore.Server.HttpSys/HttpSysListener.cs
@@ -315,7 +315,7 @@ internal unsafe bool ValidateAuth(NativeRequestContext requestMemory)
             return true;
         }
 
-        private unsafe void SendError(ulong requestId, int httpStatusCode, IList<string> authChallenges)
+        internal unsafe void SendError(ulong requestId, int httpStatusCode, IList<string> authChallenges = null)
         {
             HttpApi.HTTP_RESPONSE_V2 httpResponse = new HttpApi.HTTP_RESPONSE_V2();
             httpResponse.Response_V1.Version = new HttpApi.HTTP_VERSION();

diff --git a/src/Microsoft.AspNetCore.Server.HttpSys/MessagePump.cs b/src/Microsoft.AspNetCore.Server.HttpSys/MessagePump.cs
@@ -165,7 +165,7 @@ private async void ProcessRequestsWorker()
                     {
                         LogHelper.LogException(_logger, "ListenForNextRequestAsync", exception);
                     }
-                    return;
+                    continue;
                 }
                 try
                 {
-Original file line number
+Diff line change
@@ Expand Up / @@ -165,7 +165,7 @@ private async void ProcessRequestsWorker() @@
                         {
                             LogHelper.LogException(_logger, "ListenForNextRequestAsync", exception);
                         }
-                        return;
+                        continue;
                     }
                     try
                     {
@@ Expand Down @@