Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various refactors including postgres portability improvements #38

Merged
merged 12 commits into from
Dec 6, 2024

Conversation

chuckadams
Copy link
Contributor

Pull Request

What changed?

  • Using epoch-seconds for timestamps instead of datetime, since pgsql and sqlite can't speak any real common dialect.
  • Remove N+1 queries for checking status and pulled time. N+1 is fine for sqlite, not for anything else.
  • Simplified internals somewhat by merging RevisionMetadataService into ListService (its only consumer)

Why did it change?

To make things work better on postgres.

Did you fix any specific issues?

nein

CERTIFICATION

By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.

@chuckadams chuckadams merged commit efa848f into main Dec 6, 2024
1 check passed
@chuckadams chuckadams deleted the chuck/dev/int-dates branch December 6, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant