Adds the spatial index type #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds initial spatial index type * I think i added tests? * I was missing a comment
* Adding some more debug values for this * Maybe? * make it a bit more concretet * correct variable casting * Adds partition methods to table * Adds diffing in one direction * Works both ways, needs to dedup though * Compares partitions in both directions correctly * Spelling mistakes and regexp greedy * Commands masked as comments for version compatability are included * Keep comments if they are actually commands * More generic end finder for regular and partition ends, added partition function/option finder * first test * Correct tests * Correct tests * doh * Adds test in other direction * Comment unused tests * Comment unused tests - but really
357r4bd
requested changes
Jul 31, 2020
There was a problem hiding this comment.
Thank you for the PR and I am sorry for the delay. Can you rebase your feature branch with current master, squash your commits down to a single one, then make sure your tests still run successfully.
The test updates are appreciated. If you see any opportunities to update the POD, please do so. Looking forward to your updated PR.
* issue aspiers#40 - should drop FKs before indexes and create FKs after indexes * Use parents to sort list of constraints * And please dont leak the password Co-authored-by: Ralph Bolton <[email protected]> Co-authored-by: _/\__/\__/\__/\_ <[email protected]>
* switch from name to concated values for fks * The names also refect the FKs
* adds new table level engine,charsets,collate * replaces row level collate/charset if matches table level
regexp stopped before partition :doh:
Co-authored-by: Oriol Francès <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
spatial indextype to the already existent indexes.Since this is my first perl PR, any pointers are appreciated.
closes: #60