Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tighten up our bzlmod deps #7

Merged
merged 1 commit into from
Oct 12, 2023
Merged

chore: tighten up our bzlmod deps #7

merged 1 commit into from
Oct 12, 2023

Conversation

alexeagle
Copy link
Member

Also green up main CI by dropping windows for now
(it fails because we don't have an Aspect CLI windows binary yet)

Also green up main CI by dropping windows for now
(it fails because we don't have an Aspect CLI windows binary yet)
@alexeagle alexeagle requested review from jbedard and kormide October 12, 2023 18:47
@@ -1,30 +1,23 @@
"Bazel dependencies"

bazel_dep(name = "aspect_rules_lint", version = "0.0.0", dev_dependency = True)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: dev_dependency is technically better here, but I just want to reduce the size of the example to make it less intimidating for casual readers

@alexeagle alexeagle merged commit 0110486 into main Oct 12, 2023
3 of 4 checks passed
@alexeagle alexeagle deleted the buildifier branch October 12, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants