Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better workaround for eslint bug #25

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Better workaround for eslint bug #25

merged 1 commit into from
Oct 19, 2023

Conversation

alexeagle
Copy link
Member

Changing to ctx.actions.run_shell caused the RUNFILES lookup logic to fail with bzlmod disabled.
(and we're missing test coverage)

Type of change

  • Bug fix (change which fixes an issue)

Test plan

  • New test cases added
    added a "happy path" eslint_test target.

@alexeagle alexeagle requested a review from gregmagolan October 19, 2023 20:55
gregmagolan
gregmagolan approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@alexeagle alexeagle merged commit 80a1458 into main Oct 19, 2023
6 checks passed
@alexeagle alexeagle deleted the js_patch branch October 19, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @gregmagolan