-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use multirun #160
Use multirun #160
Conversation
a69b729
to
b9f78e7
Compare
awesome! |
06e1117
to
d158620
Compare
This introduces a dep on rules_python, purely to run a |
my take on this is that since we don't allow users to pass args per binary like multirun, we can get away with a simple bash script it seems... i don't like rules_python dependency here, eventhough it's indirect. |
Simple bash script cannot run the tools in parallel without interleaving their stdouts though. So we need something more. |
610a238
to
49ea5ea
Compare
This reverts commit 6df95c6.
This has the side-effect of making a formatter binary per-language, which was one of our design review outcomes, since Aspect Workflows might want to be able to run them individually or in parallel.
FYI @keith since it's taking a dependency on your repo
Also now formats-in-parallel using the
jobs
attribute ofmultirun
.Type of change
For changes visible to end-users
multi_formatter_binary
is renamed toformat_multirun
and some attributes were renamed:sh
is nowshell
protobuf
is nowprotocol_buffer
.Test plan