Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multirun #160

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Use multirun #160

merged 3 commits into from
Mar 8, 2024

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented Feb 23, 2024

This has the side-effect of making a formatter binary per-language, which was one of our design review outcomes, since Aspect Workflows might want to be able to run them individually or in parallel.

FYI @keith since it's taking a dependency on your repo

Also now formats-in-parallel using the jobs attribute of multirun.

Type of change

  • Refactor (a code change that neither fixes a bug or adds a new feature)

For changes visible to end-users

  • Breaking change (this change will force users to change their own code or config)

multi_formatter_binary is renamed to format_multirun and some attributes were renamed:

  • sh is now shell
  • protobuf is now protocol_buffer.

Test plan

  • Covered by existing test cases

@alexeagle alexeagle marked this pull request as ready for review February 23, 2024 15:34
@keith
Copy link

keith commented Feb 23, 2024

awesome!

@alexeagle
Copy link
Member Author

This introduces a dep on rules_python, purely to run a py_binary. We kinda hate that so adding @thesayyn to make any alternative suggestions :)

@thesayyn
Copy link
Member

my take on this is that since we don't allow users to pass args per binary like multirun, we can get away with a simple bash script it seems... i don't like rules_python dependency here, eventhough it's indirect.

@alexeagle
Copy link
Member Author

Simple bash script cannot run the tools in parallel without interleaving their stdouts though. So we need something more.

@alexeagle alexeagle force-pushed the use_multirun branch 2 times, most recently from 610a238 to 49ea5ea Compare March 8, 2024 20:34
@alexeagle alexeagle merged commit 6df95c6 into main Mar 8, 2024
8 checks passed
@alexeagle alexeagle deleted the use_multirun branch March 8, 2024 21:27
alexeagle added a commit that referenced this pull request Mar 14, 2024
alexeagle added a commit that referenced this pull request Mar 14, 2024
* Revert "Use multirun (#160)"

This reverts commit 6df95c6.

* chore: minimize delta from main

* chore: docs update
alexeagle added a commit that referenced this pull request Mar 27, 2024
alexeagle added a commit that referenced this pull request Mar 27, 2024
alexeagle added a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants