Add lint aspect for Ruff #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexeagle
reviewed
Oct 16, 2023
tokongs
force-pushed
the
tobias/ruff
branch
2 times, most recently
from
296798e to
81fce5d
Compare
|
Oh, can you sign our CLA also? We need legal permission to use your work. |
alexeagle
force-pushed
the
tobias/ruff
branch
from
2180bd1 to
284b29c
Compare
alexeagle
force-pushed
the
tobias/ruff
branch
from
284b29c to
614ba25
Compare
alexeagle
force-pushed
the
tobias/ruff
branch
from
769ca70 to
b961498
Compare
|
Thanks for the quick feedback! I'm just awaiting a go-ahead from legal at my workplace before signing the CLA. |
|
@alexeagle I'm sadly not quite sure I'll be able to sign the CLA with the current License the project has, as we will not be able to use it. |
|
I'll close this for now, but I can re-open it in the future if the license changes. Thanks for the rapid feedback and sorry for not seeing the license earlier! |
|
This repo is now licensed Apache 2.0, largely because I think we'll only get critical mass of linter integrations with contributions like this one :) |
|
Nice! I've signed the CLA now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project looks interesting!
I thought I'd try it out by creating a lint aspect for Ruff. And with that done, I might as well submit a PR for it too.
This adds support for the Ruff Python linter. I was unsure how you'd like to structure the binary download in the example.
Type of change
For changes visible to end-users
Test plan