fix: remove clumsy prettier plugin hoisting (#417)

It didn't work correctly because prettier runs outside the sandbox and finds node_modules in the source tree. Instead the plugin loading should be explicit, and point prettier at the right config file
aspect-build · Oct 23, 2024 · ce99c2b · ce99c2b
1 parent d66e9ae
commit ce99c2b
Show file tree

Hide file tree

Showing 8 changed files with 1,035 additions and 447 deletions.
diff --git a/docs/format.md b/docs/format.md
diff --git a/example/BUILD.bazel b/example/BUILD.bazel
@@ -41,9 +41,13 @@ js_library(
 js_library(
     name = "stylelintrc",
     srcs = ["stylelint.config.mjs"],
-    deps = [
-        ":node_modules/stylelint-config-standard",
-    ],
+    deps = [":node_modules/stylelint-config-standard"],
+)
+
+js_library(
+    name = "prettierrc",
+    srcs = ["prettier.config.cjs"],
+    deps = [":node_modules/prettier-plugin-sql"],
 )
 
 # NB: this alias does NOT cause Bazel's Loading phase to load the tools/BUILD file.

diff --git a/example/MODULE.bazel b/example/MODULE.bazel
@@ -46,7 +46,6 @@ npm.npm_translate_lock(
     pnpm_lock = "//:pnpm-lock.yaml",
     public_hoist_packages = {
         "typescript-eslint": [""],
-        "prettier-plugin-sql": [""],
     },
 )
 use_repo(npm, "npm")

diff --git a/example/package.json b/example/package.json
@@ -13,15 +13,5 @@
     "stylelint-config-standard": "^36.0.1",
     "typescript": "4.9.5",
     "typescript-eslint": "^7.10.0"
-  },
-  "//FIXME(alexeagle)": "This section shouldn't be needed since these are plugins",
-  "pnpm": {
-    "packageExtensions": {
-      "prettier": {
-        "peerDependencies": {
-          "prettier-plugin-sql": "*"
-        }
-      }
-    }
   }
 }