Skip to content

Commit

Permalink
chore: remove Go
Browse files Browse the repository at this point in the history
We don't have any Go sources in rules_lint so there's no reason we should install a Go toolchain or worry about upgrading it. 'aspect configure' provides the auto-generation for bzl_library targets so we don't need Gazelle either.
  • Loading branch information
alexeagle committed Feb 5, 2024
1 parent d3b8dcf commit c58b3a1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 15 deletions.
11 changes: 0 additions & 11 deletions BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,11 +0,0 @@
load("@gazelle//:def.bzl", "gazelle", "gazelle_binary")

gazelle_binary(
name = "gazelle_bin",
languages = ["@bazel_skylib_gazelle_plugin//bzl"],
)

gazelle(
name = "gazelle",
gazelle = "gazelle_bin",
)
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Otherwise later tooling on CI may yell at you about formatting/linting violation

Some targets are generated from sources.
Currently this is just the `bzl_library` targets.
Run `bazel run //:gazelle` to keep them up-to-date.
Run `aspect configure` to keep them up-to-date.

## Using this as a development dependency of other rules

Expand Down
5 changes: 2 additions & 3 deletions MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ bazel_dep(name = "rules_buf", version = "0.1.1")

# Needed due to rules_proto leaking the dependency
bazel_dep(name = "protobuf", version = "21.7", repo_name = "com_google_protobuf")
bazel_dep(name = "rules_go", version = "0.39.1", repo_name = "io_bazel_rules_go")

bazel_dep(name = "gazelle", version = "0.31.0", dev_dependency = True)
bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.4.1", dev_dependency = True)
# Needed to get the 'go_context' symbol, to invoke golangci-lint
bazel_dep(name = "rules_go", version = "0.39.1", repo_name = "io_bazel_rules_go")

0 comments on commit c58b3a1

Please sign in to comment.