Skip to content

Commit

Permalink
Revert "Revert "feat: start testing on Bazel 8 (#401)" (#404)"
Browse files Browse the repository at this point in the history
This reverts commit 8734743.
  • Loading branch information
alexeagle authored Oct 9, 2024
1 parent 559ed12 commit 7efe4a4
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 10 deletions.
9 changes: 1 addition & 8 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,11 @@ concurrency:

jobs:
bazel-test:
uses: bazel-contrib/.github/.github/workflows/bazel.yaml@v6
uses: bazel-contrib/.github/.github/workflows/bazel.yaml@bazel8
with:
folders: '[".", "example"]'
# Don't try for Windows support yet.
exclude_windows: true
# Root module is bzlmod-only and uses newer stardoc that requires Bazel 7.
# Example uses incompatible_enable_proto_toolchain_resolution
exclude: |
[
{"bzlmodEnabled": false, "folder": "."},
{"bazelversion": "6.4.0"}
]

integration-test:
runs-on: ubuntu-latest
Expand Down
1 change: 1 addition & 0 deletions MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ bazel_dep(name = "aspect_bazel_lib", version = "2.7.7")
# Minimum version needs 'chore: bump bazel-lib to 2.0 by @alexeagle in #1311'
# to allow users on bazel-lib 2.0
bazel_dep(name = "aspect_rules_js", version = "1.40.0")
bazel_dep(name = "bazel_features", version = "1.18.0")
bazel_dep(name = "bazel_skylib", version = "1.4.2")
bazel_dep(name = "platforms", version = "0.0.7")
bazel_dep(name = "rules_multirun", version = "0.9.0")
Expand Down
3 changes: 3 additions & 0 deletions docs/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# This load statement must be in the docs/ package rather than anything users depend on
# so that the dependency on stardoc doesn't leak to them.
load("@aspect_bazel_lib//lib:docs.bzl", "stardoc_with_diff_test", "update_docs")
load("@bazel_features//private:util.bzl", "lt")

stardoc_with_diff_test(
name = "lint_test",
Expand Down Expand Up @@ -35,6 +36,8 @@ stardoc_with_diff_test(
stardoc_with_diff_test(
name = "format",
bzl_library_target = "//format:defs",
# See https://github.com/bazel-contrib/bazel_features/pull/75
target_compatible_with = ["@platforms//:incompatible"] if lt("8.0.0-pre.20240911.1") else [],
)

stardoc_with_diff_test(
Expand Down
4 changes: 2 additions & 2 deletions docs/format.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7efe4a4

Please sign in to comment.