Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '.babelrc' to npmignore #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jluxenberg
Copy link

react-native projects use Babel 6 and the current .babelrc
in version 0.1.12 published on npm is incompatible with Babel 6.

The babelrc file for an npm module should not be in the npm
package at all, since transpilation should be done before publishing
to npm, so we add .babelrc file to the npmignore file.

See similar issue in redux-thunk for more details
reduxjs/redux-thunk#43

react-native projects use Babel 6, is incompatible with this
project's .babelrc. The babelrc file for an npm module should 
not be in the npm package at all, since transpilation should be 
done before publishing to npm, so we add .babelrc file to the 
npmignore file.

See similar issue in redux-thunk for more details
  reduxjs/redux-thunk#43
@raineorshine
Copy link

This should be ready to merge.

@ashaffer Let me know if you need contributor support! There are only a few issues, and I doubt this will iterate much given how small the scope is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants