Fix bug and security hotspot reported by Sonarqube

aservo · Oct 24, 2023 · 44e8da2 · 44e8da2
1 parent d525f6b
commit 44e8da2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/de/aservo/confapi/crowd/service/SettingsBrandingServiceImpl.java b/src/main/java/de/aservo/confapi/crowd/service/SettingsBrandingServiceImpl.java
@@ -111,7 +111,7 @@ private LookAndFeelConfiguration getLookAndFeelConfiguration() {
     private ImageInfo getImageInfo(InputStream inputStream) {
         ImageInfo imageInfo;
         try {
-            File file = File.createTempFile("image", null);
+            File file = File.createTempFile("image", "file", new File("/tmp/confapi"));
             FileUtils.copyInputStreamToFile(inputStream, file);
             String contentType = file.toURI().toURL().openConnection().getContentType();
 

diff --git a/src/test/java/de/aservo/confapi/crowd/service/ApplicationLinksServiceTest.java b/src/test/java/de/aservo/confapi/crowd/service/ApplicationLinksServiceTest.java
@@ -117,7 +117,7 @@ public void testSetApplicationLinks()
         ApplicationLinksBean applicationLinkResponse = applicationLinkService.setApplicationLinks(applicationLinksBean, true);
 
         assertEquals(applicationLinkResponse.getApplicationLinks().iterator().next().getName(), applicationLinkBean.getName());
-        assertNotEquals(applicationLinkResponse, applicationLinkBean);
+        assertEquals(applicationLinkResponse.getApplicationLinks().iterator().next().getUuid(), applicationLinkBean.getUuid());
     }
 
     @Test