Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usage notice in readme file #4

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brettaufheber
Copy link
Member

No description provided.

@brettaufheber brettaufheber force-pushed the feature/readme_update branch from 20d017d to 3bc7976 Compare January 9, 2023 05:57
@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@peterhoepfl peterhoepfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Parameter PATH_PREFIX is missing in the documentation.
Also the prefix is not reflected in the urls in the diagram.
And for the proxy additional settings may be necessary, the following list is not final:
Header always set Access-Control-Allow-Credentials "true"
        Header always set Access-Control-Allow-Headers ""
        Header always set Access-Control-Allow-Origin "
"
        Header always set Access-Control-Expose-Headers "Content-Security-Policy, Location"
        Header always set Access-Control-Allow-Methods "*"
These headers were required in an test environemnt to make the preflight call of the browser to the server succeed.

@brettaufheber brettaufheber marked this pull request as draft May 2, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants