feat(golang-rewrite): misc. plugin improvements #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stratus3D
commented
Dec 14, 2024
| err = versions.InstallOneVersion(conf, plugin, toolVersion, false, os.Stdout, os.Stderr) | ||
| if err != nil { | ||
| failTest(l, "install exited with an error") | ||
| } |
There was a problem hiding this comment.
Plugin test command needs to install a tool version to verify the plugin is behaving correctly.
Stratus3D
commented
Dec 14, 2024
| if err != nil { | ||
| os.Exit(1) | ||
| return err | ||
| } |
There was a problem hiding this comment.
List all command should print an error and exit if plugin is not installed.
Stratus3D
commented
Dec 14, 2024
| @@ -153,6 +154,8 @@ func InstallOneVersion(conf config.Config, plugin plugins.Plugin, versionStr str | |||
| "ASDF_CONCURRENCY": asdfConcurrency(conf), | |||
| } | |||
|
|
|||
| env = execenv.MergeEnv(execenv.SliceToMap(os.Environ()), env) | |||
There was a problem hiding this comment.
Install callback needs to run in an environment that has the above variables set, along with env vars that were set at the time asdf was invoked.
* Correct the environment `bin/install` runs in * Improve output of `asdf list all` command when plugin not found * Update `asdf plugin test` command to install a tool version in the test
Stratus3D
force-pushed
the
tb/plugin-improvements
branch
from
3c4d1c9 to
408f8b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bin/installruns inasdf list allcommand when plugin not foundasdf plugin testcommand to install a tool version in the test