feat(golang-rewrite): PluginAdd function #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stratus3D
commented
Feb 28, 2024
| @@ -1,6 +1,5 @@ | |||
| /installs | |||
| /downloads | |||
| /plugins | |||
There was a problem hiding this comment.
This directory now contains the Golang plugin package.
Stratus3D
commented
Feb 28, 2024
| github.com/mitchellh/go-homedir v1.1.0 | ||
| github.com/sethvargo/go-envconfig v1.0.0 | ||
| github.com/stretchr/testify v1.8.4 |
There was a problem hiding this comment.
I've been trying to avoid adding dependencies but I really like testify's simple API for assertions.
Stratus3D
force-pushed
the
tb/plugin-add-command
branch
2 times, most recently
from
a8ce976 to
c951220
Compare
* Add go-git as a dependency * Remove plugins dir from gitignore * Move config code to config package * Create validatePluginName function * Create PluginDirectory function * Create PluginExists function * Implement PluginAdd function * Add testify as a dependency * Write test for PluginAdd happy path
Stratus3D
force-pushed
the
tb/plugin-add-command
branch
from
c951220 to
752dd49
Compare
|
I've merged this PR so I can keep moving forward, but feedback is still welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a
PluginAddfunction that will eventually be called by theasdf plugin addcommand, which hasn't been set up yet. A similarPluginAddFromRepofunction will be created next to install plugins from the plugins repo. Both functions will be called from theasdf plugin addcommand code.Changes in this PR:
go-git/v5as a dependency for working with Git reposPluginAddfunctionAs always, ALL feedback is welcome! I'm a complete novice at Golang trying my best to find the Golang way of doing things.