feat(golang-rewrite): add config methods #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stratus3D
commented
Feb 21, 2024
| type PluginRepoCheckDuration struct { | ||
| Never bool | ||
| Every int | ||
| } |
There was a problem hiding this comment.
Still not confident this is the way to go, but it works. Any user of this just needs to know that Every should only be used when Never is set to false.
Stratus3D
commented
Feb 21, 2024
| @@ -61,7 +139,7 @@ func loadConfigEnv() (Config, error) { | |||
| return config, err | |||
| } | |||
|
|
|||
| func LoadSettings(asdfrcPath string) (Settings, error) { | |||
| func loadSettings(asdfrcPath string) (Settings, error) { | |||
There was a problem hiding this comment.
No reason for this to be public.
Stratus3D
commented
Feb 21, 2024
| }, nil | ||
| } | ||
|
|
||
| func YesNoToBool(section *ini.Section, key string, defaultValue bool) bool { | ||
| func yesNoToBool(section *ini.Section, key string, defaultValue bool) bool { |
There was a problem hiding this comment.
No reason for this to be public.
* Create PluginRepoCheckDuration struct to represent config value * Make some functions private * write basic tests for Config methods * Add Loaded field to Settings struct * Define constants for config default values
Stratus3D
force-pushed
the
tb/config-api
branch
from
a1e3363 to
f0bbe8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO