Fix current version breaking side menu (remove bootstrap, custom css, custom js, custom template) #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
The above changes are mostly motivated by an issue where the old version of bootstrap causes the side/navigation menu to refuse to scroll. Making the above changes fixes this issue.
One side-effect of the above changes is the loss of the
details
button which collapses and expands some portions of the schema description. This seems like a reasonable loss for the benefit of not having to maintain all of the above items (which are currently causing the above described issue).As the CI here doesn't provide previews for rendered docs I opened a test PR with asdf-standard that uses the source branch for this PR:
asdf-format/asdf-standard#418
the rendered docs for the test PR are here:
https://asdf-standard--418.org.readthedocs.build/en/418/
Here are a few useful comparisons:
core/asdf
:core/complex
:For
core/asdf
the current docs contain the following:with details "expanded":
with this PR the docs contain:
Test PRs are also open for stdatamodels and rad:
spacetelescope/stdatamodels#246
spacetelescope/rad#354
The formatting for these is slightly different and are subject to the numerous bugs in the stsci sphinx theme.