update private block api usage #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
braingram
force-pushed
the
immutable_block_manager
branch
from
dae8695 to
f026439
Compare
eslavich
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASDF PR: asdf-format/asdf#1537
changes some of the internal API for block management and access that sphinx-asdf currently relies on for displaying ASDF blocks.
This PR updates sphinx-asdf to be compatible with both the old and new internal APIs.
I currently have the asdf source branch for asdf-format/asdf#1537 configured to build documentation from the sphinx-asdf source branch for this PR.
I will leave this as draft for now. Once we decide on the internal API changes in asdf-format/asdf#1537 we can bring this out of draft (after updating it with any necessary changes), merge and release sphinx-asdf then bump the required minimum version so it should be ready for an eventual release of ASDF 3.0.