Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update downstream jobs to run on python 3.12 #1876

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Dec 10, 2024

Description

roman_datamodels (one of the packages we test in our downstream CI) now requires at least python 3.11. This PR updates the python versions used for our downstream testing to python 3.12 (from python 3.10).

The specutils failure is caused by gwcs and is fixed in spacetelescope/gwcs#508 which is unreleased. I'm ok with this failing until a gwcs release is made.

The weldx failure is due to a pin for asdf < 4. We could consider disabling that job but I'm ok with it being a known failure.

Tasks

  • run pre-commit on your machine
  • run pytest on your machine
  • Does this PR add new features and / or change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update relevant docstrings and / or docs/ page
    • for any new features, add unit tests
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: bug fix
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@braingram braingram marked this pull request as ready for review December 10, 2024 15:18
@braingram braingram requested a review from a team as a code owner December 10, 2024 15:18
@braingram braingram merged commit 4bfb1fb into asdf-format:main Dec 10, 2024
53 of 62 checks passed
@braingram braingram deleted the fix_downstream branch December 10, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants