Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop s390x, update ci #1818

Merged
merged 1 commit into from
Aug 6, 2024
Merged

drop s390x, update ci #1818

merged 1 commit into from
Aug 6, 2024

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Aug 5, 2024

This PR removes the currently failing s390x workflow.
https://github.com/asdf-format/asdf/actions/runs/10245071412

On main this workflow tests 2 architectures

  • arm64: the tests for this are passing on main but take 2.5 hours due to architecture emulation. This could more easily be covered by using the mac runners which this PR achieves.
  • s390x: this is failing due an error building psutil. I am not sure why it's failing but I don't think it's worth trying to maintain a workflow for this rare architecture. If it's critical for distributions that package asdf (like debian) I believe they are more well-suited to testing with this architecture.

This PR includes a change updating the python version for a few CI jobs. The mac one was required as python 3.9 (the version on main) prevents use of macosx-latest: https://github.com/OpenAstronomy/github-actions-workflows/blob/924441154cf3053034c6513d5e06c69d262fb9a6/tools/tox_matrix.py#L139

The others are:

  • drop python 3.9 from devdeps as many libraries are dropping python 3.9 support
  • increase python version from 3.9 to 3.11 for compatibility and windows tests. These are unrelated but seem worth doing as python 3.9 is less common.

Checklist:

  • pre-commit checks ran successfully
  • tests ran successfully
  • for a public change, a changelog entry was added
  • for a public change, documentation was updated
  • for any new features, unit tests were added

@braingram braingram marked this pull request as ready for review August 5, 2024 13:43
@braingram braingram requested a review from a team as a code owner August 5, 2024 13:43
@braingram braingram changed the title drop s390x update ci drop s390x, update ci Aug 5, 2024
@braingram braingram enabled auto-merge August 6, 2024 13:20
@braingram braingram merged commit d05d388 into asdf-format:main Aug 6, 2024
32 checks passed
@braingram braingram deleted the drop_s390x branch August 6, 2024 13:26
@braingram braingram mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants