MNT: handle a deprecation warning from attrs v24.1.0
#1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
mnt/follow_attrs_depr
branch
from
adfa36e to
14ea0af
Compare
neutrinoceros
changed the title
attrs v24.1.0
1 task
5 tasks
braingram
approved these changes
Aug 4, 2024
|
@neutrinoceros asdf 3.4.0 (with these changes) is up on pypi. Let me know if you run into more issues and thanks again for the fix. |
|
Awesome, thank you very much ! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
attrs24.1.0 (released yesterday) deprecated thehashargument in favor ofunsafe_hashFor simplicity of implementation, I also bumped the minimal requirement to 22.2.0, which added the
unsafe_hashargument.xref python-attrs/attrs#1323
For context, I noticed this because it breaks astropy's CI, so please let me know if this patch can be released promptly or not. We'll be able to adapt in any case.
Checklist: