Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get tags for rtd #1794

Merged
merged 1 commit into from
Jul 11, 2024
Merged

get tags for rtd #1794

merged 1 commit into from
Jul 11, 2024

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Jul 11, 2024 •
edited
Loading

Applies changes from spacetelescope/jwst#8633

to allow removal of the stable branch (RTD will automatically generate one since we're semantically versioned).

I've already renamed the stable branch to "old_stable".

@braingram braingram requested a review from a team as a code owner July 11, 2024 15:23
@braingram braingram requested a review from jhunkeler July 11, 2024 15:28
@zacharyburnett
Copy link
Member

Screenshot 2024-07-11 at 11 34 13 AM

@braingram braingram merged commit c2cce40 into asdf-format:main Jul 11, 2024
34 of 35 checks passed
@braingram braingram deleted the rtd_unshallow branch July 11, 2024 15:37
@zacharyburnett
Copy link
Member

zacharyburnett commented Jul 11, 2024 •
edited
Loading

unfortunately it looks like the current stable docs didn't pick up the tags:
Screenshot 2024-07-11 at 11 43 36 AM

I reran the stable build to see if that fixes it

@braingram
Copy link
Contributor Author

This sort of worked :-/
Screenshot 2024-07-12 at 5 34 36 PM

@braingram braingram mentioned this pull request Jul 12, 2024
Closed
@jhunkeler
Copy link

jhunkeler commented Jul 12, 2024 •
edited
Loading

Clearing the repo's dirty flag may be the only way to produce the expected version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyburnett zacharyburnett zacharyburnett approved these changes

@jhunkeler jhunkeler Awaiting requested review from jhunkeler

Assignees
No one assigned
Labels
no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@braingram @zacharyburnett @jhunkeler