Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused _warn_tag_mismatch and _warned_tag_pairs #1786

Merged
merged 1 commit into from
Jun 20, 2024
Merged

remove unused _warn_tag_mismatch and _warned_tag_pairs #1786

merged 1 commit into from
Jun 20, 2024

Conversation

braingram
Copy link
Contributor

@braingram braingram commented May 13, 2024 •
edited
Loading

These are unused as seen in the coverage (and searching the asdf and downstream code):
https://app.codecov.io/gh/asdf-format/asdf/blob/main/asdf%2F_asdf.py#L1600

and appear to be related to the removed TypeIndex and could have been removed in: #1637

Checklist:

  • pre-commit checks ran successfully
  • tests ran successfully
  • for a public change, a changelog entry was added
  • for a public change, documentation was updated
  • for any new features, unit tests were added

@braingram braingram marked this pull request as ready for review May 13, 2024 18:56
@braingram braingram requested a review from a team as a code owner May 13, 2024 18:56
@braingram braingram requested a review from zacharyburnett June 20, 2024 13:32
@braingram braingram force-pushed the warn_tag_mismatch branch from 7e9db33 to b859784 Compare June 20, 2024 13:32
@braingram
Copy link
Contributor Author

The weldx failure is unrelated and due to numpy 2.0.

@braingram braingram merged commit abb9500 into asdf-format:main Jun 20, 2024
47 of 48 checks passed
@braingram braingram deleted the warn_tag_mismatch branch June 20, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyburnett zacharyburnett zacharyburnett approved these changes

Assignees
No one assigned
Labels
Downstream CI no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braingram @zacharyburnett