Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use openastronomy github action for release #1761

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Feb 26, 2024

Description

Update the "release" publish-to-pypi.yml workflow to use the OpenAstronomy publish_pure_python action.

Checklist:

  • pre-commit checks ran successfully
  • tests ran successfully
  • for a public change, a changelog entry was added
  • for a public change, documentation was updated
  • for any new features, unit tests were added

Copy link
Member

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you can also add this as a build check to every pull requests

Comment on lines +3 to +6
on:
release:
types: [released]
workflow_dispatch:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on:
release:
types: [released]
workflow_dispatch:
on:
release:
types: [released]
pull_request:
workflow_dispatch:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

PRs are currently tested using the OpenAstronomy workflow in the package step:

package:
needs: [core, asdf-schemas]
uses: OpenAstronomy/github-actions-workflows/.github/workflows/publish_pure_python.yml@v1
with:
python-version: "3.11"
upload_to_pypi: false
upload_to_anaconda: false
test_extras: tests
test_command: pytest --pyargs asdf

I'll take a look at combining these in a follow-up PR.

.github/workflows/publish-to-pypi.yml Outdated Show resolved Hide resolved
@braingram braingram merged commit 2c1f6b7 into asdf-format:main Feb 27, 2024
14 checks passed
@braingram braingram deleted the release_workflow branch February 27, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants