remove warning filter in pytest plugin #1757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the warnings filter in the asdf pytest plugin that was converting (most) warnings to errors:
asdf/pytest_asdf/plugin.py
Lines 242 to 245 in fcff366
This filter is preventing all other warning filtering from having any effect. This is currently making it difficult to make the downstream weldx job pass as pandas is triggering a warning during several of the schema tests. Ideally we could ignore this warning (as it's a deprecation warning that weldx will need to address) by adding a filter to the weldx tox environment. However this is not possible because of the above warnings filter. Instead we would have to add the pandas warning to the pytest plugin warnings filter. With this PR we can add the warning filter to the tox.ini and it will have an effect.
As this PR removes the warnings filter internal to the asdf pytest plugin this does mean that any library that relied on this to turn warnings into errors during schema tests will need to add their own warnings filter (if they don't already have one).
Checklist: