Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch setuptools-scm write_to (deprecated) to version_file #1743

Merged
merged 1 commit into from
Feb 29, 2024
Merged

switch setuptools-scm write_to (deprecated) to version_file #1743

merged 1 commit into from
Feb 29, 2024

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Jan 30, 2024 •
edited
Loading

Description

Switch setuptools-scm write_to (deprecated) to the non-deprecated version_file.

Fixes #1742

Checklist:

  • pre-commit checks ran successfully
  • tests ran successfully
  • for a public change, a changelog entry was added
  • for a public change, documentation was updated
  • for any new features, unit tests were added

@braingram braingram marked this pull request as ready for review February 15, 2024 17:05
@braingram braingram requested a review from a team as a code owner February 15, 2024 17:05
@braingram braingram force-pushed the scm_version_file branch 2 times, most recently from 87eecda to 76c8ed0 Compare February 27, 2024 14:59
@zacharyburnett
Copy link
Member

SCSB-138

@braingram braingram merged commit 15e830d into asdf-format:main Feb 29, 2024
34 checks passed
@braingram braingram deleted the scm_version_file branch February 29, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyburnett zacharyburnett zacharyburnett approved these changes

Assignees
No one assigned
Labels
no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update setuptools_scm write_to
2 participants
@braingram @zacharyburnett