Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix non public submodules with _ #1689

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Prefix non public submodules with _ #1689

merged 4 commits into from
Dec 5, 2023

Conversation

braingram
Copy link
Contributor

Description

This PR adds _ to a number of non-public submodules to make their status more explicit:

  • asdf.compression
  • asdf.entry_points
  • asdf.core
  • asdf.extern

Checklist:

  • pre-commit checks ran successfully
  • tests ran successfully
  • for a public change, a changelog entry was added
  • for a public change, documentation was updated
  • for any new features, unit tests were added

@braingram braingram marked this pull request as ready for review November 16, 2023 21:06
@braingram braingram requested a review from a team as a code owner November 16, 2023 21:06
@braingram braingram merged commit a3bf1a5 into asdf-format:main Dec 5, 2023
44 checks passed
@braingram braingram deleted the prefix_non_public branch December 5, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eslavich eslavich eslavich approved these changes

Assignees
No one assigned
Labels
Downstream CI no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braingram @eslavich