Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Py312 #1651

Closed
wants to merge 4 commits into from
Closed

TEST: Py312 #1651

wants to merge 4 commits into from

Conversation

braingram
Copy link
Contributor

Removes fsspec from our test dependencies to allow the python 3.12 tests to run.

Based off changes in: #1633

tox.ini Outdated Show resolved Hide resolved
@braingram braingram marked this pull request as draft September 26, 2023 20:26
@pllim
Copy link
Contributor

pllim commented Sep 28, 2023

Hmm I am seeing this downstream. How did you get past it?

asdf/_jsonschema/_format.py:494: in <module>
    import isoduration
isoduration/__init__.py:3: in <module>
    from isoduration.parser import parse_duration
isoduration/parser/__init__.py:2: in <module>
    from isoduration.parser.parsing import parse_date_duration
isoduration/parser/parsing.py:4: in <module>
    import arrow  # type: ignore
arrow/__init__.py:2: in <module>
    from .api import get, now, utcnow
arrow/api.py:12: in <module>
    from arrow.arrow import TZ_EXPR, Arrow
arrow/arrow.py:32: in <module>
    from dateutil import tz as dateutil_tz
dateutil/tz/__init__.py:2: in <module>
    from .tz import *
dateutil/tz/tz.py:37: in <module>
    EPOCH = datetime.datetime.utcfromtimestamp(0)
E   DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version.
Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).

@braingram
Copy link
Contributor Author

@pllim that appears to be an issue with dateutil fixed: dateutil/dateutil#1285
It's likely not seen here as nothing requires the optional isoduration dependency (which is using dateutil).

@pllim
Copy link
Contributor

pllim commented Sep 28, 2023

We don't either, but it got imported by asdf like this:

asdf/_jsonschema/_format.py:494: in <module>
    import isoduration

Weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants