Add support for python 3.12 #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
force-pushed
the
py312
branch
3 times, most recently
from
3258c19 to
7cd4dc8
Compare
braingram
added a commit
to braingram/asdf
that referenced
this pull request
Sep 11, 2023
Add support for python 3.12
This was referenced Sep 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing (by cleaning up out test dependencies that don't yet support python 3.12) revealed only 1 required change to allow asdf to support python 3.12, removal of one use of
utcfromtimestamp:asdf/asdf/asdf.py
Lines 1339 to 1341 in cee306e
The tests can be found here: #1633
This change was broken out into this PR to make backporting easier. Python 3.12 will be released 2023-10-02 and we may want to consider releasing a 2.15.2 that includes the change in this PR even if we release 3.0 before that time (so users that can't yet update to 3.0 have an option to run 3.12).
Updating the CI to test python 3.12 would ideally be included in this PR but given the lack of released 3.12 support for some test dependencies (astropy) and the changes required to work around these limitations (see #1633) I propose that we separate this change from the dependency cleanup and rely on the tests in #1633 to show expected python 3.12 compatibility once all the dependencies are updated.