Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslavich simpler integer type #1624

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Aug 10, 2023

This PR includes changes that were in #1527 re-based to #1625

Closes #1621
Closes #1347

@braingram braingram force-pushed the eslavich-simpler-integer-type branch 2 times, most recently from a00c3f5 to 95da481 Compare August 10, 2023 21:50
@braingram braingram force-pushed the eslavich-simpler-integer-type branch from bcc8a45 to 3c724f1 Compare August 28, 2023 16:39
@braingram braingram force-pushed the eslavich-simpler-integer-type branch from 3c724f1 to 2965b88 Compare September 8, 2023 13:33
@braingram braingram added this to the 3.0.0 milestone Sep 11, 2023
@braingram braingram force-pushed the eslavich-simpler-integer-type branch from 2965b88 to 5b57dc2 Compare September 20, 2023 13:18
@braingram braingram changed the title TEST: Eslavich simpler integer type Eslavich simpler integer type Sep 20, 2023
@braingram braingram force-pushed the eslavich-simpler-integer-type branch from 5b57dc2 to b44b37f Compare September 29, 2023 13:16
@braingram braingram marked this pull request as ready for review September 29, 2023 13:16
@braingram braingram requested a review from a team as a code owner September 29, 2023 13:16
Copy link
Contributor

@eslavich eslavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's got my name in the title, how could I disapprove???

@braingram braingram force-pushed the eslavich-simpler-integer-type branch from b44b37f to 68a2577 Compare September 29, 2023 16:53
@braingram
Copy link
Contributor Author

Closing and reopening to re-trigger RTD. It 'failed' on 'uploading'.

@braingram braingram closed this Sep 29, 2023
@braingram braingram reopened this Sep 29, 2023
@braingram
Copy link
Contributor Author

stdatamodels CI will fail as the MIRI apcorr reference files on CRDS were updated without updating the associated schema.

@braingram braingram merged commit 1201a46 into asdf-format:main Sep 29, 2023
52 of 55 checks passed
@braingram braingram deleted the eslavich-simpler-integer-type branch September 29, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move IntegerType to a Converter Remove IntegerType value caching
2 participants