Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'name' and 'version' attributes from NDArrayType instances #1031

Merged

Conversation

eslavich
Copy link
Contributor

@eslavich eslavich commented Dec 2, 2021

@CagtayFabry what do you think about this alternative fix? My concern with #1016 is that we won't catch all the cases where an NDArrayType is created.

Resolves #1015

@eslavich eslavich added the bug label Dec 2, 2021
@eslavich eslavich added this to the 2.8.2 milestone Dec 2, 2021
@CagtayFabry
Copy link
Contributor

@CagtayFabry what do you think about this alternative fix? My concern with #1016 is that we won't catch all the cases where an NDArrayType is created.

Resolves #1015

this looks like a much cleaner solution, thanks!

@perrygreenfield
Copy link
Contributor

Just to clarify, the idea here is to effectively remove these attributes from the class instances, but not the class itself (which the tag machinery would use)?

@eslavich
Copy link
Contributor Author

eslavich commented Dec 3, 2021

Just to clarify, the idea here is to effectively remove these attributes from the class instances, but not the class itself (which the tag machinery would use)?

Yes, just so!

Copy link
Contributor

@perrygreenfield perrygreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eslavich eslavich merged commit 926ffe0 into asdf-format:master Dec 3, 2021
@eslavich eslavich deleted the eslavich-alternate-ndarraytype-fix branch December 3, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NDArrayType attributes when reading from tree
3 participants