use legacy_class_names instead of ignoring missing BuiltinExtension

asdf-format · Sep 29, 2023 · fbcc1f9 · fbcc1f9
1 parent 0bb89bf
commit fbcc1f9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/asdf/asdf.py b/asdf/asdf.py
@@ -294,12 +294,6 @@ def _check_extensions(self, tree, strict=False):
             return
 
         for extension in tree["history"]["extensions"]:
-            # asdf 3.0 removed the BuiltinExtension and handles all
-            # core objects with a ManifestExtension so don't warn if
-            # a file is opened that was created with an older asdf
-            # which used the BuiltinExtension (which is no longer installed)
-            if extension.get("extension_class", None) == "asdf.extension.BuiltinExtension":
-                continue
             installed = None
             for ext in self._user_extensions + self._plugin_extensions:
                 if (

diff --git a/asdf/core/_extensions.py b/asdf/core/_extensions.py
@@ -48,4 +48,9 @@
 ]
 
 
-EXTENSIONS = [ManifestExtension.from_uri(u, converters=CONVERTERS, validators=VALIDATORS) for u in MANIFEST_URIS]
+EXTENSIONS = [
+    ManifestExtension.from_uri(
+        u, converters=CONVERTERS, validators=VALIDATORS, legacy_class_names=["asdf.extension.BuiltinExtension"]
+    )
+    for u in MANIFEST_URIS
+]