Skip to content

Commit

Permalink
temporarily skip fsspec tests
Browse files Browse the repository at this point in the history
  • Loading branch information
braingram committed Aug 21, 2023
1 parent d947849 commit ac83837
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 5 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ jobs:
default_python: '3.12.0-rc.1'
envs: |
- linux: devdeps
setenv: |
AIOHTTP_NO_EXTENSIONS: 1
dev:
needs: [core, asdf-schemas]
Expand Down
7 changes: 6 additions & 1 deletion asdf/_tests/test_asdf.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import os

import fsspec
import pytest

from asdf import config_context, get_config
Expand Down Expand Up @@ -392,11 +391,14 @@ def test_unclosed_file(tmp_path):
pass


@pytest.importorskip('fsspec')
def test_fsspec(tmp_path):
"""
Issue #1146 reported errors when opening a fsspec 'file'
This is a regression test for the fix in PR #1226
"""
import fsspec

tree = {"a": 1}
af = AsdfFile(tree)
fn = tmp_path / "test.asdf"
Expand All @@ -407,13 +409,16 @@ def test_fsspec(tmp_path):
assert_tree_match(tree, af.tree)


@pytest.importorskip('fsspec')
@pytest.mark.remote_data()
def test_fsspec_http(httpserver):
"""
Issue #1146 reported errors when opening a fsspec url (using the http
filesystem)
This is a regression test for the fix in PR #1228
"""
import fsspec

tree = {"a": 1}
af = AsdfFile(tree)
path = os.path.join(httpserver.tmpdir, "test")
Expand Down
7 changes: 6 additions & 1 deletion asdf/_tests/test_generic_io.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import sys
import urllib.request as urllib_request

import fsspec
import numpy as np
import pytest

Expand Down Expand Up @@ -788,11 +787,14 @@ def test_io_subclasses(tmp_path):
f.close()


@pytest.importorskip('fsspec')
def test_fsspec(tmp_path):
"""
Issue #1146 reported errors when opening a fsspec 'file'
This is a regression test for the fix in PR #1226
"""
import fsspec

ref = b"01234567890"
fn = tmp_path / "test"

Expand All @@ -809,13 +811,16 @@ def test_fsspec(tmp_path):
assert ai == i


@pytest.importorskip('fsspec')
@pytest.mark.remote_data()
def test_fsspec_http(httpserver):
"""
Issue #1146 reported errors when opening a fsspec url (using the http
filesystem)
This is a regression test for the fix in PR #1228
"""
import fsspec

ref = b"01234567890"
path = os.path.join(httpserver.tmpdir, "test")

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ docs = [
'tomli; python_version < "3.11"',
]
tests = [
"fsspec[http]>=2022.8.2",
#"fsspec[http]>=2022.8.2",
"lz4>=0.10",
"psutil",
"pytest>=6",
Expand Down

0 comments on commit ac83837

Please sign in to comment.