default memmap=False

asdf-format · Nov 8, 2024 · 739dba2 · 739dba2
1 parent 2ed29f0
commit 739dba2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/asdf/_asdf.py b/asdf/_asdf.py
@@ -57,7 +57,8 @@ def __init__(
         extensions=None,
         version=None,
         ignore_unrecognized_tag=False,
-        memmap=True,
+        ignore_implicit_conversion=NotSet,
+        memmap=False,
         lazy_load=True,
         custom_schema=None,
     ):
@@ -88,7 +89,7 @@ def __init__(
 
         memmap : bool, optional
             When `True`, when reading files, attempt to memmap underlying data
-            arrays when possible. Defaults to ``True``.
+            arrays when possible. Defaults to ``False``.
 
         lazy_load : bool, optional
             When `True` and the underlying file handle is seekable, data
@@ -1510,7 +1511,7 @@ def open_asdf(
     extensions=None,
     ignore_unrecognized_tag=False,
     _force_raw_types=False,
-    memmap=True,
+    memmap=False,
     lazy_tree=NotSet,
     lazy_load=True,
     custom_schema=None,
@@ -1549,7 +1550,7 @@ def open_asdf(
 
     memmap : bool, optional
         When `True`, when reading files, attempt to memmap underlying data
-        arrays when possible. Defaults to ``True``.
+        arrays when possible. Defaults to ``False``.
 
     lazy_load : bool, optional
         When `True` and the underlying file handle is seekable, data

diff --git a/changes/1801.general.rst b/changes/1801.general.rst
@@ -0,0 +1 @@
+set ``memmap=False`` by default