Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace usages of copy_arrays with memmap #46

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

zacharyburnett
Copy link
Member

follow-on to asdf-format/asdf#1797

@zacharyburnett zacharyburnett self-assigned this Jul 18, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@zacharyburnett zacharyburnett marked this pull request as ready for review July 18, 2024 15:15
@zacharyburnett zacharyburnett requested a review from a team as a code owner July 18, 2024 15:15
@braingram
Copy link
Contributor

I think for this package we want to just bump the minimum to the version with memmap:

"asdf >= 3.0.0",

Would you update this to 3.1.0?

Copy link
Contributor

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@braingram braingram merged commit 5315399 into asdf-format:main Jul 18, 2024
16 checks passed
@zacharyburnett zacharyburnett deleted the deprecate/copy_arrays branch July 18, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants