Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add resources symlink #416

Merged
merged 1 commit into from
Jan 29, 2024
Merged

add resources symlink #416

merged 1 commit into from
Jan 29, 2024

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Dec 12, 2023 •
edited
Loading

This PR adds a symlink ink src/asdf-standard to the resources directory (and excludes this symlink from packaging). This allows editable installs of asdf-standard to use importlib.resources to inspect resources.

This is the first PR in a 3 part series to hopefully break the link between asdf-standard and asdf which prevents asdf-standard from adding a new standard without breaking asdf tests. The general plan is:

@braingram braingram mentioned this pull request Dec 12, 2023
Closed
5 tasks
@braingram braingram requested a review from eslavich December 12, 2023 22:16
@braingram braingram marked this pull request as ready for review December 12, 2023 22:16
@braingram
add resources symlink
3150878 
this allows editable installs to find
asdf_standard.resources during an editable
install (via importlib.resources.files)
eslavich
eslavich approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@eslavich eslavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@braingram braingram merged commit c6dd92d into asdf-format:main Jan 29, 2024
14 checks passed
@braingram braingram deleted the symlink_resources branch January 29, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eslavich eslavich eslavich approved these changes

Assignees
No one assigned
Labels
no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braingram @eslavich