Fix missing groovydocs #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
fix-missing-groovydocs
branch
from
10470dc to
26ff373
Compare
|
Working fine in my fork, all "active"* correctly generating and pointing to their API / groovydocs. * I have maintained the current modules that are activated in the main build. It seems some like "slides" seem to be disabled temporarily but without much detail, I don't date doing heavier changes. |
tylerbertrand
pushed a commit
to tylerbertrand/asciidoctor-gradle-plugin
that referenced
this pull request
Apr 12, 2024
Fix missing groovydocs not being collected during combineDocs task. 'docs' module build script reformatted and fix docs adding all required groovydoc tasks as a dependency for combineDocs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing groovydocs not being collected during docs publication.
TLDR; only some groovydoc tasks run, but do during configuration phase of the included build (from
docssub gradle). Feels like an un-intended side effect.To fix it, I reformatted things (it's opinionated) to help me understand how it works, but the actual fix is adding all required
groovydoctasks as a dependency forcombineDocs.