Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gh-pages docs publication #719

Merged

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented Feb 27, 2024

Found an issue where enabling 'antora' sub-modules causes commits with git-publish to be empty. For now simply remove antora module, the goal is to get base documents up again since we have had already some users asking.
I have not reviewed the docs btw, I want to first fix the infra.

  • CI:
    • Set write permissions
    • Update active branches
    • Use GH Actions token
  • gh-pages Gradle script
    • Update active branches
    • Inject repo from CI env var
  • Update .sdkmanrc to Java 11
  • Update URL in readme to point to 'master' folder in gh-pages branch.
  • Some documents fixes

@abelsromero abelsromero force-pushed the fix-gh-pages-publication branch from b1c2d65 to 5252301 Compare February 27, 2024 22:26
Found an issue where enabling 'antora' sub-modules causes commits with
git-publish to be empty. For now simply remove antora module.
* CI:
  * Set write permissions
  * Update active branches
  * Use GH Actions token
* gh-pages Gradle script
  * Update active branches
  * Inject repo from CI env var
* Update .sdkmanrc to Java 11
* Some documents fixes
@abelsromero
Copy link
Member Author

You can see this changes working in my fork https://github.com/abelsromero/asciidoctor-gradle-plugin/commits/gh-pages/

@abelsromero
Copy link
Member Author

I'll merge this and continue working on docs (end goal, getting antora docs in https://docs.asciidoctor.org/) same time tomorrow if there are no objections.

@abelsromero abelsromero merged commit 1a46d02 into asciidoctor:master Feb 28, 2024
3 checks passed
tylerbertrand pushed a commit to tylerbertrand/asciidoctor-gradle-plugin that referenced this pull request Apr 12, 2024
* CI:
  * Set write permissions
  * Update active branches
  * Use GH Actions token
* gh-pages Gradle script
  * Update active branches
  * Inject repo from CI env var
  * Disable antora module: using it breaks git-publish
* Update .sdkmanrc to Java 11
* Some documents fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant