Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ready for 4.0.1 to go to master #705

Merged
merged 29 commits into from
Jan 9, 2024
Merged

Ready for 4.0.1 to go to master #705

merged 29 commits into from
Jan 9, 2024

Conversation

ysb33r
Copy link
Member

@ysb33r ysb33r commented Jan 9, 2024

No description provided.

ysb33r and others added 29 commits January 8, 2024 18:25
- On Gradle 7.6 - 8.3, leak some Gradle libraries onto the classpath
  in order to allow closure extensions to still work.
- On Gradle 8.4+, throw an exception and tell the build script author
  to convert the closure into a string or place it in a file.
- Add support for providers to strings or files.
- Allow for external dependencies to be added.

Closes #697
* chore(deps): update actions/checkout action to v4

* Remove workaround

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Goooler <[email protected]>
Otherwise the value of 'org.gradle.jvm.version' is set to the JVM used during build

Fixes #702
…e-module-minimal-jvm

Set Java Toolchain to enforce module JVM to 8
* chore(deps): update dependency gradle to v7.6.3

* Migrate Copy task

* Remove outdated Gradle version checkers

* Try to fix `Can generate a asciidoctorconfigfile`

* Remove sourceCompatibility & targetCompatibility after using toolchain

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Goooler <[email protected]>
@ysb33r ysb33r added this to the 4.0 milestone Jan 9, 2024
@ysb33r ysb33r requested a review from aalmiray January 9, 2024 15:57
Copy link
Member

@aalmiray aalmiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only thing I'm not fond of is the fixed serial Uid values to an arbitrary number instead of the computed one by the IDE. But that's alright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants