-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ready for 4.0.1 to go to master #705
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- On Gradle 7.6 - 8.3, leak some Gradle libraries onto the classpath in order to allow closure extensions to still work. - On Gradle 8.4+, throw an exception and tell the build script author to convert the closure into a string or place it in a file. - Add support for providers to strings or files. - Allow for external dependencies to be added. Closes #697
…issue Schalk/debug groovy project issue
* chore(deps): update actions/checkout action to v4 * Remove workaround --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Goooler <[email protected]>
Minor updates
Otherwise the value of 'org.gradle.jvm.version' is set to the JVM used during build Fixes #702
…e-module-minimal-jvm Set Java Toolchain to enforce module JVM to 8
* chore(deps): update dependency gradle to v7.6.3 * Migrate Copy task * Remove outdated Gradle version checkers * Try to fix `Can generate a asciidoctorconfigfile` * Remove sourceCompatibility & targetCompatibility after using toolchain --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Goooler <[email protected]>
Gradle 7.6.3
aalmiray
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The only thing I'm not fond of is the fixed serial Uid values to an arbitrary number instead of the computed one by the IDE. But that's alright
This was referenced Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.