Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Java Toolchain to enforce module JVM to 8 #703

Conversation

abelsromero
Copy link
Member

Otherwise the value of 'org.gradle.jvm.version' is set to the JVM used during build.

@abelsromero
Copy link
Member Author

I see development-4.x branch has a quick fix for the description too, but that is removing the actual description in the POM and simply inserting a dot. I think we should fix it too before any patch release.

@abelsromero
Copy link
Member Author

I think GH is about to crash, I saw the "oops page" and CI is showing weird errors.

I validated the change locally building with JDK 11 and checking the modules

find . -name "asciidoctor-gradle-*.module" -exec cat {} \; | grep 'org.gradle.jvm.version'

image

Without the fix I saw 11.

Otherwise the value of 'org.gradle.jvm.version' is set to the JVM used during build

Fixes asciidoctor#702
@abelsromero abelsromero force-pushed the set-java-toolchain-to-enforce-module-minimal-jvm branch from 085fa24 to 5f041e3 Compare January 9, 2024 13:05
@ysb33r ysb33r merged commit f1ca768 into asciidoctor:development-4.x Jan 9, 2024
3 checks passed
@ysb33r ysb33r added this to the 4.0.0 milestone Jan 9, 2024
@Goooler Goooler mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants