Skip to content
This repository has been archived by the owner on Oct 17, 2021. It is now read-only.

Do not depend on deprecated md5 #32

Closed
wants to merge 1 commit into from

Conversation

florentx
Copy link
Contributor

Change the filters latex and music to avoid depending on a deprecated module.

Module hashlib exists since Python 2.5.
https://docs.python.org/2/library/hashlib.html

@michel-kraemer
Copy link
Contributor

+1
I'm not a Python expert though, so someone else should approve and merge.

Cheers,
Michel

@elextr
Copy link
Contributor

elextr commented May 29, 2014

Unfortunately hashlib is only available on 2.5 or newer, but Asciidoc states it supports 2.4 as well. My understanding was that was because of Jython support, but Jython has been at 2.5 for several years now so that impediment to requiring a newer version no longer exists.

Nevertheless I think we should request comment on the ML just in case there is some impediment we don't know about, then move the required version to 2.5 before this is committed.

@florentx
Copy link
Contributor Author

Funny, because until #27 is merged, the latex filter breaks compatibility with Python < 2.7 ;)

I think it would be a good move to bump the minimal Python version to 2.5 (or 2.6), because it will be difficult to avoid breaking compatibility if we don't have all the obsolete Python versions to run the tests. And Travis-CI covers only Python >= 2.6.
However in my working environment, sometimes I run the tests with Python 2.5 too.

@elextr
Copy link
Contributor

elextr commented May 29, 2014

So if there are any users of versions of Python older than 2.7 they can't use the latex filter since there have been no complaints :) Although the change has been since the previous release.

The argument that older versions are not generally available is a good point in favour of updating the required version even further.

Perhaps you could point out the argument for 2.6 in reply to the ML RFC I just sent.

@aerostitch
Copy link
Contributor

And I think this one should be merged before #115 too. If we do a release, maybe not ship deprecated deps. ;)

@elextr
Copy link
Contributor

elextr commented Sep 29, 2017

@aerostitch for Python 2 md5 is never going to be removed despite deprecation. I don't want to make any changes the day before release.

@aerostitch
Copy link
Contributor

Makes sense. Thanks!

@aerostitch
Copy link
Contributor

Seems this change has been integrated in https://github.com/asciidoc/asciidoc-py3
@elextr as the last release on this repo has already been cut and this repo deprecated, should we keep this one open?

@elextr
Copy link
Contributor

elextr commented Oct 7, 2018

@aerostitch yes, done.

@elextr elextr closed this Oct 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants