organise client and core code #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 8 out of 12 changed files in this pull request and generated no suggestions.
Files not reviewed (4)
- examples/random_color.py: Evaluated as low risk
- tests/conftest.py: Evaluated as low risk
- tests/clients/test_blinkstick.py: Evaluated as low risk
- src/blinkstick/init.py: Evaluated as low risk
move the main client classes (BlinkStick, BlinkStickPro, BlinkStickProMatrix) to a clients package Also, move the core functions (find_first etc) to core module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant refactoring to improve the organization of the BlinkStick codebase. The changes primarily involve moving code related to BlinkStick clients into a new
clientsmodule and updating import statements accordingly.Refactoring for better organization:
examples/random_color.py: Updated import statements to reflect the new module structure, and changed the method call toblinkstick.core.find_first().src/blinkstick/__init__.py: Moved BlinkStick-related imports to theclientsmodule and updated the import paths for core functions.src/blinkstick/clients/__init__.py: Added imports forBlinkStick,BlinkStickPro, andBlinkStickProMatrixand included them in__all__.src/blinkstick/core.py: Created a new core module with functions to find BlinkStick devices and get the package version.Test updates to match new structure:
test_blinkstick.py,test_blinkstick_matrix.py,test_blinkstick_pro_matrix.py, andconftest.py. [1] [2] [3] [4]