Add tests for string to bytes conversion and refactor #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make `_data_to_message` a standalone function, move it to a `utilities` package, and rename
* restrict info block data string to 31 bytes * correctly handle empty string
robberwick
force-pushed
the
_data_to_message
branch
from
daccf29 to
ab1d58d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
blinkstickpackage, focusing on refactoring code and adding new utility functions and tests. The most important changes involve moving a helper method to a utility module and updating the code to use this new method.Refactoring and code improvements:
src/blinkstick/blinkstick.py: Removed the_data_to_messagemethod and replaced its usage with the newstring_to_info_block_datafunction. [1] [2] [3]src/blinkstick/utilities.py: Added thestring_to_info_block_datafunction to convert a string to a byte array of 32 bytes, filling the rest of the bytes with zeros.Testing:
tests/utilities/test_string_to_info_block.py: Added tests for thestring_to_info_block_datafunction to ensure it correctly converts strings to byte arrays, handles empty strings, truncates long strings, and processes strings with exactly 31 characters.