-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add battery leveling firmware #14
Open
rnpnr
wants to merge
9
commits into
develop
Choose a base branch
from
batt_leveling
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnpnr
force-pushed
the
batt_leveling
branch
3 times, most recently
from
March 28, 2020 21:35
9808af8
to
56466f7
Compare
also initialize subscibers for all batteries remaining TODO is the voltage src swapping function
some delay may be needed between the calls to digitalWrite() this will need to be determined in testing
right now we only publish: ee_batt enabled or disabled motor_batts enabled or disabled more info could be provided if needed. for instance, we can sense a short on any of the LM5050 chips but right now we aren't making use of that info.
we don't need to use the motor batteries until the ee battery has dropped below a certain threshold. for now this will be 15v but it can be changed if needed.
Looks good to me. I'll wait to merge until we've tested this on the real hardware. |
this series of commits closes #10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delay in
loop()
might need to be adjusted. Right now it effects the publishing rate. We might also want to force a publish immediately after swapping srcs. Currently there will be a delay equal the value inloop()
. It might not matter if this delay gets changed.The following needs to be tested when we have access to hardware: